feat(amplify-frontend-javascript): generate amplifyconfiguration.json for JS projects #13246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
Sep 19, 2023
packages/amplify-e2e-tests/src/__tests__/aws-exports/js-frontend-config.test.ts
Outdated
Show resolved
Hide resolved
packages/amplify-e2e-tests/src/__tests__/aws-exports/js-frontend-config.test.ts
Outdated
Show resolved
Hide resolved
sobolk
previously approved these changes
Sep 19, 2023
Tested with the Next.js sample app that's deployed to Vercel and Amplify Hosting, using the newly generated |
rtpascual
previously approved these changes
Sep 20, 2023
sobolk
approved these changes
Sep 20, 2023
rtpascual
approved these changes
Sep 20, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
To support NextJS SSR and ESM projects, generate an additional file for amplify JS projects
Description of how you validated changes
Verified that valid configuration is rendered for amplify js projects manually & e2e testing.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.