fix: don't render spinner in non-TTY terminal #13242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR makes Spinner noop in non-TTY terminals.
Customers who spawn CLI process as child process or stream logs to files observe control characters and transitions in output. These are not needed in these scenarios and only obscure output.
Issue #, if available
Description of how you validated changes
Before change - log to file
After change - log to file
TTY
(see spinner next to "This will take few minutes", the other is harder to catch as it uploads faster).
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.