fix: add better error messaging when initializing an already initialized project #13166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtpascual
commented
Aug 29, 2023
rtpascual
commented
Aug 29, 2023
bombguy
previously approved these changes
Aug 30, 2023
sobolk
reviewed
Sep 6, 2023
…ult env" This reverts commit b52152f.
rtpascual
changed the title
bombguy
reviewed
Sep 20, 2023
packages/amplify-e2e-tests/src/__tests__/init-special-case.test.ts
Outdated
Show resolved
Hide resolved
bombguy
previously approved these changes
Sep 20, 2023
sobolk
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Catch earlier and provide better error messaging when initializing an already initialized project with defaults (running
amplify init -yfor an already initialized project).The error message changed when running
amplify init -ythe second time:Invalid environment name: undefined->Amplify project <appId> is already initialized with environment <currentEnv>Issue #, if available
Fixes #11579
Description of how you validated changes
Added unit test for running
amplify init -yfor an initialized project and expecting the new error message.Manually ran
amplify-dev init -ytwice, the second time gives the new error message (the same applies if initializing an app with a custom env name then runningamplify-dev init -y):Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.