fix: move data schema generator to separate package #2426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the typescript dep BREAKING CHANGE: Data schema functionality removed.
dpilch
force-pushed
the
data-schema-generator
branch
from
c54b0ab to
9403889
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Move TS data schema generator to a separate package. The TS dependency is significantly increasing the CLI binary size. The TS data schema generator functionality is not supported on the Gen 1 CLI.
This will be a breaking change on the
@aws-amplify/graphql-schema-generatorpackage. This package is not intended to be directly used by customers. The API category and the CLI will NOT incur a breaking change.Gen 2 will need to be updated to use the new package: https://github.com/aws-amplify/amplify-backend/blob/54c69c44e1dbc1a897da09e5576891aa7ad8185c/packages/schema-generator/package.json#L20
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
aws-amplify/amplify-cli#13681
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.