fix(auth) Add underlying cause to fetchAuthSession error (#2750)

Co-authored-by: Matt Creaser <[email protected]>
aws-amplify · Apr 1, 2024 · 0f61cc8 · 0f61cc8
1 parent 30a288e
commit 0f61cc8
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/aws-core/src/main/java/com/amplifyframework/auth/CognitoCredentialsProvider.kt b/aws-core/src/main/java/com/amplifyframework/auth/CognitoCredentialsProvider.kt
@@ -47,7 +47,8 @@ open class CognitoCredentialsProvider @InternalAmplifyApi constructor(
                         AuthException(
                             "Failed to get credentials. " +
                                 "Check if you are signed in and configured identity pools correctly.",
-                            AmplifyException.TODO_RECOVERY_SUGGESTION
+                            AmplifyException.TODO_RECOVERY_SUGGESTION,
+                            authSession.toAWSAuthSession()?.awsCredentialsResult?.error
                         )
                     )
                 },

diff --git a/aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt b/aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
@@ -254,7 +254,7 @@ internal class LivenessWebSocket(
                     PredictionsException(
                         "Failed to start the face liveness session.",
                         error,
-                        AmplifyException.TODO_RECOVERY_SUGGESTION
+                        AmplifyException.RECOVERY_SUGGESTION_WITH_THROWABLE
                     )
                 )
             }

diff --git a/core/src/main/java/com/amplifyframework/AmplifyException.java b/core/src/main/java/com/amplifyframework/AmplifyException.java
@@ -19,6 +19,8 @@
 import androidx.annotation.Nullable;
 import androidx.core.util.ObjectsCompat;
 
+import com.amplifyframework.annotations.InternalAmplifyApi;
+
 import java.util.Objects;
 
 /**
@@ -29,7 +31,13 @@ public class AmplifyException extends Exception {
      * All Amplify Exceptions should have a recovery suggestion. This string can be used as a filler until one is
      * defined but should ultimately be replaced.
      */
-    public static final String TODO_RECOVERY_SUGGESTION = "Sorry, we don't have a suggested fix for this error yet.";
+    public static final String TODO_RECOVERY_SUGGESTION = "Sorry, we don’t have a recovery suggestion for this error.";
+
+    /**
+     * This string is intended for internal use only.
+     */
+    @InternalAmplifyApi
+    public static final String RECOVERY_SUGGESTION_WITH_THROWABLE = "See the attached exception for more details";
 
     /**
      * A common recovery suggestion for errors that are unexpected and could be originated from a bug.

diff --git a/core/src/main/java/com/amplifyframework/auth/exceptions/UnknownException.kt b/core/src/main/java/com/amplifyframework/auth/exceptions/UnknownException.kt
@@ -31,6 +31,6 @@ open class UnknownException(
 ) {
     companion object {
         const val RECOVERY_SUGGESTION_WITH_THROWABLE = "See the attached exception for more details"
-        const val RECOVERY_SUGGESTION_WITHOUT_THROWABLE = "Sorry, we don't have a suggested fix for this error yet."
+        const val RECOVERY_SUGGESTION_WITHOUT_THROWABLE = "Sorry, we don’t have a recovery suggestion for this error."
     }
 }