Skip to content

Commit

Permalink
Merge pull request #41 from alxndr/backbone-update
Browse files Browse the repository at this point in the history
Region.ensureEl() -> Region._ensureElement()
  • Loading branch information
davidvanleeuwen committed Oct 14, 2014
2 parents 150ce50 + ea9cd36 commit 3bd480b
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion backbone.marionette.modals-min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backbone.marionette.modals.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backbone.modal-bundled-min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion backbone.modal-bundled.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backbone.modal-min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/vendor/backbone.marionette.modals.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions examples/vendor/marionette.js
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,7 @@ _.extend(Marionette.Region.prototype, Backbone.Events, {
// or just before closing the view, respectively.
show: function(view){

this.ensureEl();
this._ensureElement();

if (view !== this.currentView) {
this.close();
Expand All @@ -913,7 +913,7 @@ _.extend(Marionette.Region.prototype, Backbone.Events, {
this.currentView = view;
},

ensureEl: function(){
_ensureElement: function(){
if (!this.$el || this.$el.length === 0){
this.$el = this.getEl(this.el);
}
Expand Down Expand Up @@ -2337,4 +2337,4 @@ _.extend(Marionette.Module, {


return Marionette;
})(this, Backbone, _);
})(this, Backbone, _);
4 changes: 2 additions & 2 deletions src/backbone.marionette.modals.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class Backbone.Marionette.Modals extends Backbone.Marionette.Region
zIndex: 0

show: (modal, options = {}) ->
@ensureEl()
@_ensureElement()

if @modals.length > 0
lastModal = _.last(@modals)
Expand Down Expand Up @@ -64,4 +64,4 @@ class Backbone.Marionette.Modals extends Backbone.Marionette.Region
Marionette.triggerMethod.call(this, "close")

closeAll: ->
@close() for modal in @modals
@close() for modal in @modals

0 comments on commit 3bd480b

Please sign in to comment.