Keep selection #47
Open
Keep selection #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaljaar
approved these changes
Feb 11, 2022
| @@ -87,6 +90,9 @@ public struct TatsiConfig { | |||
| LocalizableStrings.tableName = localizableStringsTableName | |||
| } | |||
| } | |||
|
|
|||
| /// Set this to a number of PHAsset instances that were selected before the picker was opened. | |||
| public var preselectedAssets: [PHAsset]? = nil | |||
There was a problem hiding this comment.
my suggestion is to declare this as an empty array like public var preselectedAssets = [PHAsset]() because that is the actual default behaviour, that none are preselected. nil as default does not have an extra meaning here over an empty array, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 options to TatsiConfig:
I want to test this options first before merging into master.
If you have code feedback, please post it here.
If you have feedback about the feature, see #44.