Skip to content

Commit

Permalink
Fix flaky package dependency tests (swiftlang#1288)
Browse files Browse the repository at this point in the history
* Seem to be intermittent failures if defaultPackage was not in the
  the workspace context as a package folder so lets be explicit

Issue: swiftlang#1258
  • Loading branch information
award999 authored Dec 19, 2024
1 parent 052d583 commit ea16da0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/integration-tests/commands/build.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ suite("Build Commands @slow", function () {
// The description of this package is crashing on Windows with Swift 5.9.x and below
if (
process.platform === "win32" &&
ctx.toolchain.swiftVersion.isLessThan(new Version(6, 0, 0))
ctx.toolchain.swiftVersion.isLessThanOrEqual(new Version(5, 9, 0))
) {
this.skip();
}
Expand Down
3 changes: 2 additions & 1 deletion test/integration-tests/ui/PackageDependencyProvider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@ suite("PackageDependencyProvider Test Suite", function () {
async setup(ctx) {
const workspaceContext = ctx;
await waitForNoRunningTasks();
await folderInRootWorkspace("defaultPackage", workspaceContext);
const folderContext = await folderInRootWorkspace("dependencies", workspaceContext);
await executeTaskAndWaitForResult((await getBuildAllTask(folderContext)) as SwiftTask);
await workspaceContext.focusFolder(folderContext);
treeProvider = new PackageDependenciesProvider(workspaceContext);
await workspaceContext.focusFolder(folderContext);
},
async teardown() {
treeProvider.dispose();
Expand Down

0 comments on commit ea16da0

Please sign in to comment.