Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.astring: A couple of strip_console_codes fixes #135

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

utils.astring: A couple of strip_console_codes fixes #135

wants to merge 4 commits into from

Conversation

ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Aug 19, 2024 •
edited
Loading

I noticed the strip_console_code works quite oddly, let's add a selftest and fix the biggest issues.

Anyway the behaviour was here for a long time so this is here just to begin some discussion.

do not merge before a proper discussion!

ldoktor added 3 commits August 19, 2024 09:50
@ldoktor
tests: Add strip_console_codes test
0a99d55 
Signed-off-by: Lukáš Doktor <[email protected]>
@ldoktor
utils.astring: Fix index usage
10da7da 
we already set the "index += len(tmp_word) + 1" before we get to this
exception so we must not add the tmp_index.

Signed-off-by: Lukáš Doktor <[email protected]>
@ldoktor
utils.astring: Enforce the console code starts with the code
506e44a 
previously we only checked the console_code is found anywhere in the
text between the two \x1b and then we blindly removed first N
characters. Let's ensure we check the console code regexp from the
beginning.

Signed-off-by: Lukáš Doktor <[email protected]>
@ldoktor ldoktor mentioned this pull request Aug 19, 2024
Draft
@ldoktor ldoktor marked this pull request as draft August 19, 2024 08:55
@smitterl
Copy link

Though I might be misunderstanding but matching only the start of a line doesn't seem to work, ref. #134 (comment)

@ldoktor
utils.astring: Add ^c, ^!p and ^]104 to skip chars
5f07ea1 
these are sometimes generated by kernel, ignore them.

Signed-off-by: Lukáš Doktor <[email protected]>
Signed-off-by: Sebastian Mitterle <[email protected]>
@ldoktor
Copy link
Contributor Author

ldoktor commented Sep 9, 2024

@smitterl I have added a commit that should address the #134, could you please take a look on whether it behaves correctly and if not how to modify the selftest to cover your scenario? Then you can port it to your PR to get things rolling and later hopefully refine this as well.

@smitterl
Copy link

smitterl commented Dec 3, 2024

@ldoktor Sorry for the late response. With this state I get an IndexError in aexpect.

[stdlog] 2024-12-03 09:14:17,560 avocado.test stacktrace       L0042 ERROR| Reproduced traceback from: /var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/avocado_vt/test.py:298
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR| Traceback (most recent call last):
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR|   File "/root/aexpect/aexpect/utils/astring.py", line 56, in strip_console_codes
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR|     special_code = re.findall(console_codes, tmp_word)[0]
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR|                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
[stdlog] 2024-12-03 09:14:17,563 avocado.test stacktrace       L0049 ERROR| IndexError: list index out of range

@ldoktor
Copy link
Contributor Author

ldoktor commented Dec 5, 2024

@ldoktor Sorry for the late response. With this state I get an IndexError in aexpect.

[stdlog] 2024-12-03 09:14:17,560 avocado.test stacktrace       L0042 ERROR| Reproduced traceback from: /var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/avocado_vt/test.py:298
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR| Traceback (most recent call last):
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR|   File "/root/aexpect/aexpect/utils/astring.py", line 56, in strip_console_codes
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR|     special_code = re.findall(console_codes, tmp_word)[0]
[stdlog] 2024-12-03 09:14:17,562 avocado.test stacktrace       L0049 ERROR|                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
[stdlog] 2024-12-03 09:14:17,563 avocado.test stacktrace       L0049 ERROR| IndexError: list index out of range

This is interesting, are you absolutely sure you're using this version of aexpect? The line 56 is inside try/except so IndexError shouldn't be possible, max it can raise ValueError with a sensible message. It'd be nice to catch the output, if possible so we can add this scenario to selftests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldoktor @smitterl