Fixed logical issue in kselftest for if/else block. #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the code logic to correctly execute the kselftest cases based on the selected component. Ex: bpf, cpufrequecy .. etc Signed-off-by: Samir Mulani <[email protected]>
PraveenPenguin
requested changes
Sep 4, 2024
| @@ -177,7 +177,7 @@ def test(self): | |||
| kself_args = self.params.get("kself_args", default='') | |||
| if self.comp == "bpf": | |||
| self.bpf() | |||
| if self.comp == "cpufreq": | |||
| elif self.comp == "cpufreq": | |||
There was a problem hiding this comment.
this will break another part of the code like result is an undefined variable, please take care of that well, easy way is to return value from cpufreq function and store in result variable
|
@SamirMulani any update here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code logic to execute the kselftest cases based on the selected component correctly.
Ex: bpf, cpufrequecy .. etc