feature: radio field #3425
Merged
feature: radio field #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit dfead97 and detected 0 issues on this pull request. View more on Code Climate. |
adrianthedev
approved these changes
Nov 14, 2024
| @@ -10,7 +10,7 @@ class Avo::Resources::Person < Avo::BaseResource | |||
|
|
|||
| def fields | |||
| field :name, as: :text, link_to_record: true, sortable: true, stacked: true | |||
| field :type, as: ::Pluggy::Fields::RadioField, name: "Type", options: {Spouse: "Spouse", Sibling: "Sibling"}, include_blank: true, filterable: true | |||
spec/system/avo/radio_field_spec.rb
Outdated
| @@ -0,0 +1,60 @@ | |||
| require "rails_helper" | |||
|
|
|||
| RSpec.describe "RadioField", type: :system do | |||
There was a problem hiding this comment.
I wonder if we can get away with a feature test instead of a system one.
thiagoyoussef
force-pushed
the
feature/radio-field
branch
from
6352b0a
to
b855474
Compare
Paul-Bob
approved these changes
Nov 15, 2024
| @@ -10,7 +10,7 @@ class Avo::Resources::Person < Avo::BaseResource | |||
|
|
|||
| def fields | |||
| field :name, as: :text, link_to_record: true, sortable: true, stacked: true | |||
| field :type, as: ::Pluggy::Fields::RadioField, name: "Type", options: {Spouse: "Spouse", Sibling: "Sibling"}, include_blank: true, filterable: true | |||
| field :type, as: :pluggy_radio, name: "Type", options: {Spouse: "Spouse", Sibling: "Sibling"}, include_blank: true, filterable: true | |||
There was a problem hiding this comment.
Is this change really necessary? I think it's a good test for declaring fields using the constant.
There was a problem hiding this comment.
Will change to use the constant then! It's not necessary, just thought would be a better practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3140
Checklist:
Screenshots & recording