Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable non standalone actions on custom controls #3365

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Oct 28, 2024

Description

Fixes #2735

Enable non standalone actions defined on self.index_controls only when a record is selected.

Related PR

https://github.com/avo-hq/avo-advanced/pull/50

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Oct 28, 2024
Copy link

codeclimate bot commented Oct 28, 2024

Code Climate has analyzed commit c52a15e and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 2

View more on Code Climate.

@Paul-Bob Paul-Bob self-assigned this Oct 28, 2024
@Paul-Bob Paul-Bob merged commit 88275b0 into main Oct 28, 2024
21 of 22 checks passed
@Paul-Bob Paul-Bob deleted the fix/disable_non_standalone_actions_on_custom_controls branch October 28, 2024 12:05
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-standalone actions should not be able to run with no records if on index_controls
1 participant