Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implicit_authorization on default authorization service #3355

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Oct 22, 2024

Description

Fixes #3327

Ensure that implicit_authorization doesn't impact community apps without custom authorization service

Apply implicit_authorization only when using a custom authorization service or the Avo::Pro::Authorization::AuthorizationService.

If the default Avo::Services::AuthorizationService is being used, bypass the implicit_authorization logic entirely.

In summary, implicit_authorization should only take effect if a custom authorization service is implemented or when using Avo Pro.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Oct 22, 2024
@github-actions github-actions bot added the Fix label Oct 22, 2024
Copy link

codeclimate bot commented Oct 22, 2024

Code Climate has analyzed commit 1a5c796 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit ba99622 into main Oct 22, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the fix/implicit_authorization branch October 22, 2024 15:49
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@davegson
Copy link

thanks a lot for your issue and the fix! 🚀 took me some painful hours to understand why as: :has_many just was not working...

@Paul-Bob
Copy link
Contributor Author

That certainly wasn’t a pleasant experience, it’s fixed on >= v3.13.7

Still has an impact on applications where Avo was installed on a version between v3.13.4 and v3.13.6.

Upgrading to >= v3.13.7 fixes it.

@Paul-Bob Paul-Bob mentioned this pull request Nov 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix config.implicit_authorization = true when no authorization client is configured.
2 participants