Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove types #3308

Merged
merged 7 commits into from
Oct 10, 2024
Merged

refactor: remove types #3308

merged 7 commits into from
Oct 10, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Oct 4, 2024 •
edited
Loading

Description

  • Remove spec.add_dependency "literal", "~> 0.2" in favor of spec.add_dependency "prop_initializer"
  • Use prop_initilizer in favor of literal
  • Remove types from components props

@Paul-Bob Paul-Bob marked this pull request as draft October 4, 2024 10:26
@github-actions github-actions bot added the Chore label Oct 4, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 4, 2024 •
edited
Loading

Code Climate has analyzed commit 39a60d4 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title chore: remove types refactor: remove types Oct 10, 2024
@Paul-Bob Paul-Bob added Refactor and removed Chore labels Oct 10, 2024
@Paul-Bob Paul-Bob self-assigned this Oct 10, 2024
@Paul-Bob Paul-Bob marked this pull request as ready for review October 10, 2024 14:05
@Paul-Bob Paul-Bob merged commit 6d91834 into main Oct 10, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the chore/remove_types branch October 10, 2024 15:22
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@simi simi mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Paul-Bob Paul-Bob

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Paul-Bob