Work without ActiveStorage

[jpawlyn]

If ActiveStorage is not included in a Rails app, then we see the error uninitialized constant Avo::Fields::Common::Files::ControlsComponent::ActiveStorage

Description

When running with eager_load set to true, when starting puma we are seeing the error:

3.3.3/lib/ruby/gems/3.3.0/gems/avo-3.12.0/app/components/avo/fields/common/files/controls_component.rb:10:in `<class:ControlsComponent>': uninitialized constant Avo::Fields::Common::Files::ControlsComponent::ActiveStorage (NameError)

  prop :file, ActiveStorage::Attachment
              ^^^^^^^^^^^^^

Fixes # (issue)

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit d316229 and detected 0 issues on this pull request.

View more on Code Climate.

[jpawlyn]

Note, we only see this issue with 3.11.8 and above - see v3.11.7...v3.11.8

[Paul-Bob]

Hello @jpawlyn, thanks for this contribution!

In the original approach, if ActiveStorage::Attachment is not defined, the prop :file would also remain undefined.

I applied a suggestion to remove the type from file to ensure the prop exists even if ActiveStorage::Attachment is not defined.