Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: main_panel extraction #2095

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: main_panel extraction #2095

merged 1 commit into from
Dec 12, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Dec 12, 2023 •
edited
Loading

Description

Main panel fields were fetched twice when only_root == false

Fixes #2077
Fixes discord thread

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots

Before

Filters

Preview

After

Filters

Preview

@Paul-Bob Paul-Bob added the Fix label Dec 12, 2023
@Paul-Bob Paul-Bob self-assigned this Dec 12, 2023
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit 9509223 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit fe206b9 into main Dec 12, 2023
12 checks passed
@Paul-Bob Paul-Bob deleted the fix/duplicated_fields_on_preview_and_filters branch December 12, 2023 16:17
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev Awaiting requested review from adrianthedev

Assignees

@Paul-Bob Paul-Bob

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix duplicated filtrable fields when inside main_panel block
1 participant
@Paul-Bob