fix: allow all chars on text filters

[Paul-Bob]

Description

Fixes #2061

1. Encode and decode filters on JS controller following mdn official documentation about "the unicode problem"
2. Un-silence decoding errors, we had some suppressed errors, that makes some bugs hard to debug and understand.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit 3ef10a8 and detected 0 issues on this pull request.

View more on Code Climate.

[yuki-yogi]

@Paul-Bob
Thanks for creating the issue.
I was about to report this issue as well.

I am attaching a video just in case.
This issue also occurs at avo 3.1.0.

filters.not.work.mov

stimulus.js:2017 Error invoking action "keypress->text-filter#tryToSubmit"

URIError: URI malformed
    at decodeURIComponent (<anonymous>)
    at n.b64DecodeUnicode (filter_controller.js:38:12)
    at n.changeFilter (filter_controller.js:50:33)
    at n.tryToSubmit (text_filter_controller.js:12:19)
    at tse.invokeWithEvent (stimulus.js:362:25)
    at tse.handleEvent (stimulus.js:329:18)
    at Xae.handleEvent (stimulus.js:31:25)

{identifier: 'text-filter', controller: n, element: div, index: 0, event: KeyboardEvent}
controller
: 
n {context: fse}
element
: 
div
event
: 
KeyboardEvent {isTrusted: true, immediatePropagationStopped: false, params: {…}, key: 'Enter', stopImmediatePropagation: ƒ, …}
identifier
: 
"text-filter"
index
: 
0
[[Prototype]]
: 
Object

[Paul-Bob]

@yuki-yogi this is actually an PR to fix this issue that was created by you! =))

[yuki-yogi]

@Paul-Bob
Ah, I understand!
Thanks for the PR response to the fix!

Looking forward to the next release.

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

[Paul-Bob]

@yuki-yogi this should be fixed on the last patch release ;)

[yuki-yogi]

@Paul-Bob
Understood. Thank you for your report!
The filter function is often used, so we look forward to seeing it fixed!

[Paul-Bob]

@yuki-yogi let us know if it works as expected on 3.1.5

[yuki-yogi]

@Paul-Bob
We immediately deployed avo 3.1.5 to the production environment and confirmed that the problem was resolved!

Thank you so much for your help.
Thanks for solving this problem, I will add self.keep_filters_panel_open = true to each resourece so that users can use the filter function more.