Fix #454, Remove (..) from types in @docs #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, thanks! A possible improvement would be to instead put the code in the markdown parser so that the invalid characters are stripped out of the AST representation. But given that the markdown parser is forked from another project and is quite confusing, I'm not sure it would be easy to do that way. |
|
@mdevlamynck oh, can you also add a line for yourself at the bottom of the list of authors in LICENSE, and make a PR indicating that you are licensing your contributions to this project under that BSD 3-Clause license |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #454.
This adds a cleanup pass before rendering the module docs content. It removes
(..)if any in theMarkdown.ElmDocs.I'm not sure if this is the best place to put this pass but I figured if it's done in the formatting function it will not break other stuff and will not miss any
(..)it's supposed to remove.I'm not very familiar with haskell so my
Text.replace (Text.pack "(..)") (Text.pack "")thing might not be the best way of doing this.