Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate all setting about log capture to nested settings #383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jansyk13
Copy link
Contributor

@jansyk13 jansyk13 commented Nov 9, 2022

No description provided.

@augi
Copy link
Member

augi commented Nov 9, 2022

The current behavior is documented here: https://github.com/avast/gradle-docker-compose-plugin/blob/main/README.md#nested-configurations

So at least, we should update the documentation.

But I'm not sure if it is a good idea to allow writing to the same file simultaneously 🤔 I'm fine with containerLogToDir but I would prefer to keep the rest (to prevent races when writing).

@augi
Copy link
Member

augi commented Aug 9, 2023

I´m afraid it would work correctly, to use the same file for writing from multiple threads 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants