Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Quiz Params #148

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Review Quiz Params #148

wants to merge 6 commits into from

Conversation

suryabulusu
Copy link
Collaborator

Fixes #{issue id}

Summary

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

pritamps
pritamps reviewed Jul 4, 2024
View reviewed changes
src/views/Player.vue
const quizDetails : QuizAPIResponse = await QuizAPIService.getQuiz(props.quizId);
let quizDetails : QuizAPIResponse;
if (props.review != null) {
quizDetails = await QuizAPIService.getReviewQuiz(props.quizId);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to check if props.review == true?

pritamps
pritamps reviewed Jul 4, 2024
View reviewed changes
Copy link

@pritamps pritamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is the AI stuff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritamps pritamps pritamps left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suryabulusu @pritamps