move setting to unhealthy after retries #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
cam-schultz
reviewed
Dec 5, 2024
relayer/listener.go
Outdated
| @@ -209,6 +208,7 @@ func (lstnr *Listener) processLogs(ctx context.Context) error { | |||
| // variables such as Quorum values and processing missed blocks. | |||
There was a problem hiding this comment.
I think we can get rid of this TODO. If implemented, we'd likely still want to mark the relayer as unhealthy after some period of time or number of failed retries. To me, there's no functional difference between that and simply retrying a fixed number of times before marking as unhealthy, as we do now.
There was a problem hiding this comment.
I removed the TODO. Thinking about this more I think we should not fatal on the unhealthy status and let the outside caller of the binary decide what to do and how long to give it to become healthy again.
cam-schultz
approved these changes
Dec 5, 2024
geoff-vball
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently the healthcheck fatals immediately on failure. This means that for intermittent connection failures this leads to a race between the reconnect setting the status back to healthy before the healthcheck is called again. If the healthcheck is called before the reconnect then the process shuts down.
Alternative and potentially cleaner approach would be to not have the healthcheck failure shut down the process but let the kubernetes or whatever manages the process to shut it down based on the failed check and additional conditions/thresholds.
How this works
Doesn't set the status to unhealthy until the reconnect attempts have failed.
How this was tested
How is this documented