Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename away from warp #551

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Rename away from warp #551

merged 11 commits into from
Nov 27, 2024

Conversation

iansuvak
Copy link
Contributor

@iansuvak iansuvak commented Nov 18, 2024 •
edited
Loading

Why this should be merged

Part of general renaming from Warp -> ICM. Closes #538

How this works

  • Renames the repo and git module awm-relayer -> icm-offchain-services
  • Renames the awm-relayer binary and expected DockerHub repo -> icm-relayer
  • Updates links and titles AWM Relayer referring to the repo in general is ICM Off-chain Services in capitalized titles

One inconsistency right now is module/repo name having a dash in Off-chain in plain text but no dash in the module and proposed repo name. I can change either to make it consistent but icm-off-chain-services seems like too many dashes for a module/repo name IMO.

How this was tested

Existing tests should pass. Once the repo is created it should be tested with new test tags.

How is this documented

Updated the docs

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 18, 2024
View reviewed changes
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
@iansuvak iansuvak added the DO NOT MERGE This PR is not meant to be merged in its current state label Nov 19, 2024
@iansuvak iansuvak marked this pull request as ready for review November 21, 2024 15:46
@iansuvak iansuvak requested a review from a team as a code owner November 21, 2024 15:46
@geoff-vball
Copy link
Contributor

Just as a note before I start reviewing. I do like icm-offchain-services and ICM Off-chain Services. 3 dashes is too many

@cam-schultz
Copy link
Collaborator

Thoughts on condensing the name to icm-service? IMO the shorter the repo name the better. I think it should be pretty obvious from the lack of smart contracts that these services are not "on chain", so the "off chain distinction" feels superfluous. In the wider context of the soon-to-be-named icm-contracts repo, having this repo be named similarly emphasizes their relationship.

@iansuvak
Copy link
Contributor Author

Thoughts on condensing the name to icm-service? IMO the shorter the repo name the better. I think it should be pretty obvious from the lack of smart contracts that these services are not "on chain", so the "off chain distinction" feels superfluous. In the wider context of the soon-to-be-named icm-contracts repo, having this repo be named similarly emphasizes their relationship.

I like icm-services

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
go.mod Fixed Show fixed Hide fixed
@iansuvak iansuvak removed the DO NOT MERGE This PR is not meant to be merged in its current state label Nov 27, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2024
View reviewed changes
go.mod
@@ -1,4 +1,4 @@
module github.com/ava-labs/awm-relayer
module github.com/ava-labs/icm-services

Check failure

Code scanning / Snyk Open Source

High severity - Dual license: GPL-3.0, LGPL-3.0 vulnerability in github.com/ava-labs/coreth/plugin/evm/message Error

This file introduces a vulnerable github.com/ava-labs/coreth/plugin/evm/message package with a high severity vulnerability.
go.mod
@@ -1,4 +1,4 @@
module github.com/ava-labs/awm-relayer
module github.com/ava-labs/icm-services

Check failure

Code scanning / Snyk Open Source

High severity - Dual license: GPL-3.0, LGPL-3.0 vulnerability in github.com/ava-labs/subnet-evm/accounts Error

This file introduces a vulnerable github.com/ava-labs/subnet-evm/accounts package with a high severity vulnerability.
go.mod
@@ -1,4 +1,4 @@
module github.com/ava-labs/awm-relayer
module github.com/ava-labs/icm-services

Check failure

Code scanning / Snyk Open Source

High severity - Dual license: GPL-3.0, LGPL-3.0 vulnerability in github.com/ethereum/go-ethereum/common Error

This file introduces a vulnerable github.com/ethereum/go-ethereum/common package with a high severity vulnerability.
go.mod
@@ -1,4 +1,4 @@
module github.com/ava-labs/awm-relayer
module github.com/ava-labs/icm-services

Check warning

Code scanning / Snyk Open Source

Medium severity - MPL-2.0 license vulnerability in github.com/hashicorp/go-bexpr Warning

This file introduces a vulnerable github.com/hashicorp/go-bexpr package with a medium severity vulnerability.
go.mod
@@ -1,4 +1,4 @@
module github.com/ava-labs/awm-relayer
module github.com/ava-labs/icm-services

Check warning

Code scanning / Snyk Open Source

Medium severity - MPL-2.0 license vulnerability in github.com/hashicorp/golang-lru/v2 Warning

This file introduces a vulnerable github.com/hashicorp/golang-lru/v2 package with a medium severity vulnerability.
go.mod
@@ -1,4 +1,4 @@
module github.com/ava-labs/awm-relayer
module github.com/ava-labs/icm-services

Check warning

Code scanning / Snyk Open Source

Medium severity - MPL-2.0 license vulnerability in github.com/hashicorp/hcl Warning

This file introduces a vulnerable github.com/hashicorp/hcl package with a medium severity vulnerability.
go.mod
@@ -1,4 +1,4 @@
module github.com/ava-labs/awm-relayer
module github.com/ava-labs/icm-services

Check warning

Code scanning / Snyk Open Source

Medium severity - MPL-2.0 license vulnerability in github.com/status-im/keycard-go/derivationpath Warning

This file introduces a vulnerable github.com/status-im/keycard-go/derivationpath package with a medium severity vulnerability.
richardpringle
richardpringle approved these changes Nov 27, 2024
View reviewed changes
Copy link

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but okay to do in a follow up

scripts/build_local_image.sh Show resolved Hide resolved
@michaelkaplan13 michaelkaplan13 merged commit a08b243 into main Nov 27, 2024
7 of 9 checks passed
@michaelkaplan13 michaelkaplan13 deleted the rename branch November 27, 2024 19:10
@iansuvak iansuvak mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoff-vball geoff-vball geoff-vball approved these changes

@richardpringle richardpringle richardpringle approved these changes

@bernard-avalabs bernard-avalabs Awaiting requested review from bernard-avalabs bernard-avalabs is a code owner automatically assigned from ava-labs/interop

@michaelkaplan13 michaelkaplan13 Awaiting requested review from michaelkaplan13 michaelkaplan13 is a code owner automatically assigned from ava-labs/interop

@cam-schultz cam-schultz Awaiting requested review from cam-schultz cam-schultz is a code owner automatically assigned from ava-labs/interop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename repo and artifacts
5 participants
@iansuvak @geoff-vball @cam-schultz @richardpringle @michaelkaplan13