use warpRequirePrimaryNetworkSigners config #537
Conversation
iansuvak
force-pushed
the
self-signing-config
branch
from
d5ee2ba
to
45889ae
Compare
iansuvak
requested review from
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
relayer/application_relayer.go
Outdated
| // this shouldn't be reachable since if we found a quorum, we should also find the requirePrimaryNetworkSigners | ||
| // but leaving the check for completeness |
There was a problem hiding this comment.
I think that's probably an indication we should be able to fetch them from the config together?
I also agree with your comment that the current WarpQuorum object is unnecessary. We can just use a uint for QuorumPercentage, or have WarpQuorum contain the percentage and requirePrimaryNetworkSigners
There was a problem hiding this comment.
I went with the latter route and renamed it to WarpConfig. It's basically identical to the source WarpConfig defined in subnet-evm but doesn't implement the Upgrade interface and when converting it we populate it with warpDefaultQuorumNumerator value if it's 0
relayer/config/config.go
Outdated
| return s.warpRequirePrimaryNetworkSigners, nil | ||
| } | ||
| } | ||
| return false, errFailedToGetWarpQuorum |
There was a problem hiding this comment.
I don't think this error should say anything about the Warp Quorum. We error here iff the destination blockchain is in the config.
There was a problem hiding this comment.
I updated the wording to indicate that the blockchainID is not in the destination blockchains. Thanks!
Why this should be merged
Fixes #454
How this works
Fetches the additional value from the config and uses it when creating application relayer struct.
Open q:
WarpQuorumstruct doesn't seem very useful since denominator is hardcoded at compile time to 100How this was tested
How is this documented