add metrics for connect/disconnect events #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
feuGeneA,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
iansuvak
force-pushed
the
connection_metrics
branch
from
2a92347 to
7935089
Compare
geoff-vball
previously approved these changes
Aug 27, 2024
cam-schultz
previously approved these changes
Aug 27, 2024
cam-schultz
reviewed
Aug 27, 2024
cam-schultz
approved these changes
Aug 27, 2024
minghinmatthewlam
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Instead of moving Connected/Disconnected log events back to info level this collects metrics on the number of connect and disconnect events that occur. As of now, the applications don't initiate any disconnects so alerts can be created to monitor for excessive disconnects initiated by network peers.
Also fixed the typo in the
app_request_network_metrics.gofilenameHow this works
I re-used recently added
AppRequestNetworkMetricsstruct since these are fundamentally still related to theAppRequestNetwork.