Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process missed blocks on startup #20
Process missed blocks on startup #20
Changes from all commits
c74ef48
1280b4a
551b90e
5ca0bd0
ba3f2fb
39fdc21
a1aab00
6913fb9
505b337
de7a347
349ac1e
162ca0d
7d07d82
9a0baa0
dc7ae3c
860f595
aa8dd8b
ac5d57d
9a51727
16af742
2bb9605
1727f90
e49395b
ebdfc79
532094c
f4d2c83
17879c0
4e5419d
cf9a0e7
9fdd275
32146a4
ce66b82
e012c4e
44384ca
e9c0b01
878d4c6
85cf76c
813a8e9
fde1675
c4e36bd
b8902c5
9bda673
48ec689
4ed7671
4cdc487
55bc03c
232f6fe
5b0cc63
995d204
e30a4ac
1e9891d
8870d8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we return []byte instead of string directly? When we write in to the file, we convert []byte to string. Also, when we use the result, we convert []byte to string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this offline, but for visibility, I chose
[]byte
in the interface so that the keys and values could be as general as possible. The underlying JSON databse uses strings so that the resulting file is human readable.