Update wallet to report tx processing duration via event handlers #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
testing-switch-to-zap
branch
from
cf8a4d4
to
292016a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
A near-term goal is deploying a service that continuously submits transactions to fuji (and eventually mainnet) and measures the duration of issuance and confirmation. This PR updates the wallet in support of this eventual service.
How this works
Updates the primary chain wallets to compute the duration of issuance and confirmation and supplies those durations to optional event handlers.
How this was tested
Added event handlers to the wallet used by e2e tests and observed the results.
Need to be documented in RELEASES.md?
N/A