Revert "fix bug in sync retries"

This reverts commit 854577f.
ava-labs · Sep 25, 2024 · 6a8cfbb · 6a8cfbb
1 parent 854577f
commit 6a8cfbb
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/x/sync/manager.go b/x/sync/manager.go
@@ -370,14 +370,14 @@ func (m *Manager) requestChangeProof(ctx context.Context, work *workItem) {
 	}
 
 	onResponse := func(ctx context.Context, _ ids.NodeID, responseBytes []byte, err error) {
+		defer m.finishWorkItem()
+
 		if err := m.handleChangeProofResponse(ctx, targetRootID, work, request, responseBytes, err); err != nil {
 			// TODO log responses
 			m.config.Log.Debug("dropping response", zap.Error(err), zap.Stringer("request", request))
 			m.retryWork(work)
 			return
 		}
-
-		m.finishWorkItem()
 	}
 
 	if err := m.sendRequest(ctx, m.config.ChangeProofClient, requestBytes, onResponse); err != nil {
@@ -428,14 +428,14 @@ func (m *Manager) requestRangeProof(ctx context.Context, work *workItem) {
 	}
 
 	onResponse := func(ctx context.Context, _ ids.NodeID, responseBytes []byte, appErr error) {
+		defer m.finishWorkItem()
+
 		if err := m.handleRangeProofResponse(ctx, targetRootID, work, request, responseBytes, appErr); err != nil {
 			// TODO log responses
 			m.config.Log.Debug("dropping response", zap.Error(err), zap.Stringer("request", request))
 			m.retryWork(work)
 			return
 		}
-
-		m.finishWorkItem()
 	}
 
 	if err := m.sendRequest(ctx, m.config.RangeProofClient, requestBytes, onResponse); err != nil {