Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using isFreePort #635

Merged
merged 3 commits into from
Aug 25, 2023
Merged

avoid using isFreePort #635

merged 3 commits into from
Aug 25, 2023

Conversation

felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented Aug 22, 2023 •
edited
Loading

Closes #647

@felipemadero felipemadero marked this pull request as draft August 22, 2023 14:18
@felipemadero felipemadero marked this pull request as ready for review August 24, 2023 12:34
@felipemadero felipemadero changed the title remove isFreePort, get free port from listen on :0 fix already bind port problems on network start/restart Aug 24, 2023
@felipemadero felipemadero changed the title fix already bind port problems on network start/restart avoid using isFreePort Aug 24, 2023
sukantoraymond
sukantoraymond approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@sukantoraymond sukantoraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felipemadero felipemadero merged commit 4a8c0d4 into main Aug 25, 2023
6 checks passed
@felipemadero felipemadero deleted the simplify-port-gen branch August 25, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukantoraymond sukantoraymond sukantoraymond approved these changes

@dasconnor dasconnor Awaiting requested review from dasconnor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avoid using isFreePort
2 participants
@felipemadero @sukantoraymond