-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(psim)!: preapre settings to launch localization modules on psim #1094
feat(psim)!: preapre settings to launch localization modules on psim #1094
Conversation
b82c944
to
e1fc9cb
Compare
Could you explain why you want to launch Localization when using Psim? My concern is that if a developer launch psim locally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will block it to prevent it from being merged.
While PSim used the Component Interface, it is concerning that it will now depend on the internal interfaces of Localization. The role of PSim, as I understand it, is to test Planning/Control under the ideal outputs of Localization/Perception. If its role is to be expanded this much, I think it warrants further discussion.
1ba91ff
to
5eb07c6
Compare
dcfffc8
to
1a91302
Compare
1a91302
to
1984332
Compare
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
1984332
to
ef76bc9
Compare
Signed-off-by: Yuki Takagi <[email protected]>
@yukkysaito |
713aa97
into
autowarefoundation:main
…utowarefoundation#1094) Signed-off-by: Yuki Takagi <[email protected]>
…utowarefoundation#1094) Signed-off-by: Yuki Takagi <[email protected]>
Description
This PR is a part of the following issue:
#1100
This PR provides launch settings to launch Localization modules on psim.
By setting
localization_sim_mode
aspose_twist_estimator
, most of localization modules without ndt_localizer will be launched.Note that the frequency of ekf_localizer and vehicle_sim are required to handle carefully. Frequency setting is under analysis and consideration.
universe PR: autowarefoundation/autoware.universe#8212
Tests performed
psim tests and scenario simulator
https://evaluation.tier4.jp/evaluation/reports/16cc961f-f08b-527a-b2fa-120dd899dd5d?project_id=prd_jt (internal link)
Note that the scenario simulator is not supported by this PR.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.