docs(autoware_lanelet2_extension): refactor document #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 16.48% 16.48%
=======================================
Files 42 42
Lines 2808 2808
Branches 1371 1371
=======================================
Hits 463 463
Misses 2252 2252
Partials 93 93
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
force-pushed
the
feat/refactor-document
branch
3 times, most recently
from
f33213b to
eed7cb3
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/refactor-document
branch
from
eed7cb3 to
f368523
Compare
soblin
requested review from
kosuke55,
Motsu-san,
mitsudome-r,
takayuki5168 and
youtalk
as code owners
mitsudome-r
reviewed
Aug 27, 2024
mitsudome-r
reviewed
Aug 27, 2024
Comment on lines
13
to
20
| - Right Of Way | ||
| - Detection Area | ||
| - Road Marking | ||
| - Bus Stop Area | ||
| - Speed Bump | ||
| - Crosswalk | ||
| - No Stopping Area | ||
| - No Parking Area | ||
| - Bus Stoop Area |
There was a problem hiding this comment.
I'm okay with the current order, but do you have any reasons why you put them in this order? Should we rearrange them in alphabetical order?
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
depends #24
MetaInfo
MetaInfo is moved to mandatory section
RightOfWay
RightOfWay is moved to the regulatory element section
Crosswalk
Crosswalk is moved to the regulatory element section
No Stopping Area
No Stopping Area is moved to the regulatory element section
no Parking Area
No Parking Area is moved to the regulatory element section
Centerline
Centerline is moved to Optional Tagging section
Related links
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.