Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lanelet2_extension): add bus_stop_area implementation #22

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

soblin
Copy link
Collaborator

@soblin soblin commented Aug 19, 2024

Description

define bus_stop_area in format_v2 namespace

https://github.com/orgs/autowarefoundation/discussions/5097

Related links

#21

Tests performed

Notes for reviewers

Interface changes

add a new map primitive under format_version2 namespace

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin force-pushed the feat/bus-stop-area branch 3 times, most recently from 8c516f4 to 0f45c85 Compare August 20, 2024 02:28
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 58.13953% with 18 lines in your changes missing coverage. Please review.

Project coverage is 16.48%. Comparing base (1d3219a) to head (be7f49a).
Report is 1 commits behind head on main.

Files Patch % Lines
autoware_lanelet2_extension/lib/bus_stop_area.cpp 48.38% 13 Missing and 3 partials ⚠️
...t2_extension/test/src/test_regulatory_elements.cpp 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   15.84%   16.48%   +0.64%     
==========================================
  Files          40       42       +2     
  Lines        2765     2808      +43     
  Branches     1348     1371      +23     
==========================================
+ Hits          438      463      +25     
- Misses       2239     2252      +13     
- Partials       88       93       +5     
Flag Coverage Δ *Carryforward flag
differential 16.48% <58.13%> (-0.26%) ⬇️
total 15.84% <ø> (ø) Carriedforward from 56f4b7f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the feat/bus-stop-area branch from 0f45c85 to a96fb01 Compare August 20, 2024 04:13
@soblin soblin marked this pull request as ready for review August 20, 2024 04:14
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for dividing PRs. It's much easier to review this.
In addition, could you provide some unit tests?

soblin added 3 commits August 20, 2024 14:24
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soblin soblin merged commit eb47361 into main Aug 23, 2024
20 of 21 checks passed
@soblin soblin deleted the feat/bus-stop-area branch August 23, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants