-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_extension): add bus_stop_area implementation #22
Conversation
8c516f4
to
0f45c85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 15.84% 16.48% +0.64%
==========================================
Files 40 42 +2
Lines 2765 2808 +43
Branches 1348 1371 +23
==========================================
+ Hits 438 463 +25
- Misses 2239 2252 +13
- Partials 88 93 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <[email protected]>
0f45c85
to
a96fb01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for dividing PRs. It's much easier to review this.
In addition, could you provide some unit tests?
...lanelet2_extension/include/autoware_lanelet2_extension/regulatory_elements/bus_stop_area.hpp
Outdated
Show resolved
Hide resolved
...lanelet2_extension/include/autoware_lanelet2_extension/regulatory_elements/bus_stop_area.hpp
Outdated
Show resolved
Hide resolved
...lanelet2_extension/include/autoware_lanelet2_extension/regulatory_elements/bus_stop_area.hpp
Outdated
Show resolved
Hide resolved
...lanelet2_extension/include/autoware_lanelet2_extension/regulatory_elements/bus_stop_area.hpp
Show resolved
Hide resolved
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional unit test was pass. https://github.com/autowarefoundation/autoware_lanelet2_extension/actions/runs/10467968639/job/28987828303?pr=22#step:7:385
Thank you for your cooperation. LGTM
Description
define bus_stop_area in format_v2 namespace
https://github.com/orgs/autowarefoundation/discussions/5097
Related links
#21
Tests performed
Notes for reviewers
Interface changes
add a new map primitive under format_version2 namespace
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.