-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update branch of scenario_simulator_v2 to master #5570
fix: update branch of scenario_simulator_v2 to master #5570
Conversation
Signed-off-by: Fumiya Watanabe <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Reason for approval:
- I tested by following steps:
- Do
git clone
theautowarefoundation/autoware
that of commit hash5c01fb0991ea70c3ccb9112ba9739511bb38a491
(12nd Dec. 2024) - Applied following commands (Reference):
- Do
$ cd /path/to/autoware
$ mkdir src
$ vim simulator.repos
(Edit the version to `master` then save&exit)
$ vcs import src < autoware.repos
$ vcs import src < simulator.repos
$ source /opt/ros/humble/setup.bash
$ sudo apt update && sudo apt upgrade
$ rosdep update
$ rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO
$ colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release
$ source install/setup.bash
$ ros2 launch scenario_test_runner scenario_test_runner.launch.py architecture_type:=awf/universe/20240605 record:=false scenario:='$(find-pkg-share scenario_test_runner)/scenario/sample.yaml' sensor_model:=sample_sensor_kit vehicle_model:=sample_vehicle
(Three scenarios were launched. The final result of them was `passed`)
I think it's okay to go with main, but since there are also version tags for scenario_simulator_v2, should we use them instead? |
Signed-off-by: Fumiya Watanabe <[email protected]>
@mitsudome-r |
* feat(.github): push version tag images (autowarefoundation#5522) * add tag pattern Signed-off-by: Yutaka Kondo <[email protected]> * fix syntax Signed-off-by: Yutaka Kondo <[email protected]> * add tags Signed-off-by: Yutaka Kondo <[email protected]> * fix prefix and suffix Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * feat(.github): add `on:push:branches:` condition to `autoware-base` workflow (autowarefoundation#5524) add paths arg Signed-off-by: Yutaka Kondo <[email protected]> * fix(.github): not push manifest if eithor `amd64` or `arm64` image is missing (autowarefoundation#5525) not push manifest if eithor amd64 or arm64 is missing Signed-off-by: Yutaka Kondo <[email protected]> * chore(autoware.repos): fix autoware.core commit hash (autowarefoundation#5530) Signed-off-by: Ryohsuke Mitsudome <[email protected]> * feat(.git): delete `-amd64` and `-arm64` image tags after pushing manifest (autowarefoundation#5526) * not push manifest if eithor amd64 or arm64 is missing Signed-off-by: Yutaka Kondo <[email protected]> * delete -amd64 and -arm64 tags Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * chore(.github): skip `free-disk-space` action if there are no changed files (autowarefoundation#5536) skip free-disk-space action Signed-off-by: Yutaka Kondo <[email protected]> * ci: enable bugprone-* warnings in clang-tidy (autowarefoundation#5543) Signed-off-by: Ryuta Kambe <[email protected]> * feat(autoware.repos): use version tag for sensor_kits (autowarefoundation#5554) Signed-off-by: Ryohsuke Mitsudome <[email protected]> * ci(pre-commit-ansible): autoupdate (autowarefoundation#5552) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * chore(deps): bump peter-evans/create-pull-request from 6 to 7 (autowarefoundation#5162) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v6...v7) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci(pre-commit-optional): autoupdate (autowarefoundation#5401) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * chore: sync files (autowarefoundation#5541) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * chore: sync files (autowarefoundation#5572) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * fix(.github): fix CODEOWNERS (autowarefoundation#5575) Update CODEOWNERS * fix: update branch of scenario_simulator_v2 to master (autowarefoundation#5570) Signed-off-by: Fumiya Watanabe <[email protected]> * feat(autoware.repos): remove `autoware_common` from `autoware.repos` (autowarefoundation#5578) * chore(.devcontainer): add `core-devel` development container (autowarefoundation#5574) add core-devel devcontainer Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> Signed-off-by: Ryohsuke Mitsudome <[email protected]> Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Fumiya Watanabe <[email protected]> Co-authored-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Ryuta Kambe <[email protected]> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <[email protected]>
Description
This PR updates the branch of scenario_simulator_v2 from
RJD-736/autoware_msgs_support
tomaster
Related link
tier4/scenario_simulator_v2@6d8ce96
How was this PR tested?
Checked following example works. Thanks to @sasakisasaki
https://tier4.github.io/scenario_simulator_v2-docs/user_guide/QuickStart/
Notes for reviewers
None.
Effects on system behavior
None.