-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_change): refactor transit failure function #9835
refactor(lane_change): refactor transit failure function #9835
Conversation
Signed-off-by: Zulfaqar Azmi <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9835 +/- ##
=======================================
Coverage 29.62% 29.62%
=======================================
Files 1452 1454 +2
Lines 108921 108917 -4
Branches 42577 42575 -2
=======================================
+ Hits 32265 32272 +7
+ Misses 73421 73410 -11
Partials 3235 3235
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
4dc7201
into
autowarefoundation:main
Description
Refactoring
canTransitToFailState
function. Reduce similar computation, and reduce nested loop. Also added debug marker for visualizing state and the transitioning reason.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.