Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_pointcloud_preprocessor): fix image display in distortion corrector #9761

Merged
merged 2 commits into from
Dec 24, 2024
Merged

fix(autoware_pointcloud_preprocessor): fix image display in distortion corrector #9761

merged 2 commits into from
Dec 24, 2024

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Dec 24, 2024 •
edited
Loading

Description

Images were displayed in the HTML table instead of the markdown table.
Which causes the images to fail to display on the Autoware documentation page.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@vividf vividf added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 24, 2024
@vividf vividf self-assigned this Dec 24, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test labels Dec 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 24, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@vividf vividf added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 24, 2024
@github-actions GitHub Actions
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-9761/
Modified URLs:

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.72%. Comparing base (57f38b7) to head (0318e05).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9761      +/-   ##
==========================================
+ Coverage   29.66%   29.72%   +0.06%     
==========================================
  Files        1449     1450       +1     
  Lines      108785   108573     -212     
  Branches    42697    42458     -239     
==========================================
+ Hits        32271    32275       +4     
+ Misses      73344    73129     -215     
+ Partials     3170     3169       -1
Flag Coverage Δ *Carryforward flag
differential 23.93% <ø> (?)
total 29.73% <ø> (+0.06%) ⬆️ Carriedforward from 57f38b7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25
Copy link
Contributor

knzo25 commented Dec 24, 2024

@vividf
Seen from github, the only difference is that this PR shows the figure centered and in bold letters.
Seen from the documentation https://autowarefoundation.github.io/autoware.universe/main/sensing/autoware_pointcloud_preprocessor/docs/distortion-corrector/
The images are broken. Will this PR fix that?

@vividf
Copy link
Contributor Author

vividf commented Dec 24, 2024

@knzo25
Yes, this PR aims to fix the broken images.

knzo25
knzo25 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vividf vividf merged commit e60245b into autowarefoundation:main Dec 24, 2024
46 of 51 checks passed
@knzo25
Copy link
Contributor

knzo25 commented Dec 24, 2024

@vividf
It seems it did not work?
https://autowarefoundation.github.io/autoware.universe/main/sensing/autoware_pointcloud_preprocessor/docs/distortion-corrector/

@vividf
Copy link
Contributor Author

vividf commented Dec 24, 2024

Not sure whether the main docs update it immediately, probably it takes time (?)
https://autowarefoundation.github.io/autoware.universe/pr-9761/sensing/autoware_pointcloud_preprocessor/docs/distortion-corrector/

@vividf
Copy link
Contributor Author

vividf commented Dec 24, 2024

@knzo25 main is updated

kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 25, 2024
@vividf @kminoda
fix(autoware_pointcloud_preprocessor): fix image display in distortio…
1e4b571 
…n corrector (autowarefoundation#9761)

fix: fix image display

Signed-off-by: vividf <[email protected]>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
@vividf @kyoichi-sugahara
fix(autoware_pointcloud_preprocessor): fix image display in distortio…
a4b41e3 
…n corrector (autowarefoundation#9761)

fix: fix image display

Signed-off-by: vividf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knzo25 knzo25 knzo25 approved these changes

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen is a code owner

@drwnz drwnz Awaiting requested review from drwnz drwnz is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu meliketanrikulu is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

Assignees

@vividf vividf

Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vividf @knzo25