feat(goal_planner): dense goal candidate sampling in BusStopArea #8795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
force-pushed
the
feat/goal_planner-sample-limit-bus-stop-area2
branch
from
7643e4b to
4f61667
Compare
github-actions
bot
removed
the
component:map
7 tasks
soblin
requested review from
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
kosuke55
reviewed
Sep 9, 2024
| if ( | ||
| parameters_.bus_stop_area.use_bus_stop_area && | ||
| !isInAreas(transformed_vehicle_footprint, bus_stop_area_polygons)) { | ||
| break; |
There was a problem hiding this comment.
Suggested change
| break; | |
| continue; |
There was a problem hiding this comment.
sorry the name of isInAreas is bad, it return true, if it intersects.
for bus stop are the footprint should be completely in the area.
better to separate functions using
- intersects
- within
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/goal_planner-sample-limit-bus-stop-area2
branch
from
80f4524 to
a2962e1
Compare
soblin
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8795 +/- ##
==========================================
- Coverage 25.13% 25.12% -0.02%
==========================================
Files 1325 1329 +4
Lines 98662 98738 +76
Branches 38132 39555 +1423
==========================================
+ Hits 24798 24805 +7
- Misses 71376 71433 +57
- Partials 2488 2500 +12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <[email protected]>
|
@kosuke55 Can you approve this ? |
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 10, 2024
…owarefoundation#8795) Signed-off-by: Mamoru Sobue <[email protected]> Signed-off-by: emuemuJP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
depends #8794
launcher PR: autowarefoundation/autoware_launch#1156
Related links
How was this PR tested?
use_bus_stop_area = false
use_bus_stop_area = true
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.