Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_adapi): use polling subscription #7588

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jun 19, 2024

Description

This PR is #7400 without polling subscriber utility, which prevents subscription wrappers from conflicting.
Related

Compared to the original PR, the following does not use polling.

  • motion.cpp: Publish function is called by topic callback
  • planning.cpp (kinematic_state): All topics must be queued
  • routing.cpp: It is referenced by different callbacks

Related links

#7400
#7400 (comment)

Tests performed

Same as #7588

Notes for reviewers

#7588
The motion node has two subscribers, which subscribe to the 'is_pause' and 'is_start' topics.
Is it sufficient to update only the on_timer function?

It needs to call change_state from the callback.

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jun 19, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review June 19, 2024 08:54
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi enabled auto-merge (squash) June 24, 2024 05:59
@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.22%. Comparing base (b764c57) to head (768efd3).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...nent_interface_utils/rclcpp/topic_subscription.hpp 58.33% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7588      +/-   ##
==========================================
+ Coverage   29.68%   30.22%   +0.53%     
==========================================
  Files        1450     1454       +4     
  Lines      108833   108868      +35     
  Branches    42740    42753      +13     
==========================================
+ Hits        32305    32900     +595     
+ Misses      73357    72751     -606     
- Partials     3171     3217      +46     
Flag Coverage Δ *Carryforward flag
differential 31.69% <87.50%> (?)
total 29.76% <ø> (+0.08%) ⬆️ Carriedforward from ab233b8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Aug 25, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 25, 2024
@mitsudome-r
Copy link
Member

@isamu-takagi Is it possible to rebase to the latest main so that we can merge this?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 17, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi changed the title feat(default_ad_api): use polling subscription feat(default_adapi): use polling subscription Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

3 participants