-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(default_adapi): use polling subscription #7588
base: main
Are you sure you want to change the base?
feat(default_adapi): use polling subscription #7588
Conversation
Signed-off-by: Takagi, Isamu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Takagi, Isamu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7588 +/- ##
==========================================
+ Coverage 29.68% 30.22% +0.53%
==========================================
Files 1450 1454 +4
Lines 108833 108868 +35
Branches 42740 42753 +13
==========================================
+ Hits 32305 32900 +595
+ Misses 73357 72751 -606
- Partials 3171 3217 +46
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request has been automatically marked as stale because it has not had recent activity. |
@isamu-takagi Is it possible to rebase to the latest main so that we can merge this? |
…ription Signed-off-by: Takagi, Isamu <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Description
This PR is #7400 without polling subscriber utility, which prevents subscription wrappers from conflicting.
Related
Compared to the original PR, the following does not use polling.
Related links
#7400
#7400 (comment)
Tests performed
Same as #7588
Notes for reviewers
It needs to call change_state from the callback.
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.