Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_avoidance_by_lane_change_module)!: prefix package and namespace with autoware #7309

Closed

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 6, 2024

Description

rename package to autoware_behavior_path_avoidance_by_lane_change_module from behavior_path_avoidance_by_lane_change_module.

Part of:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 6, 2024
@satoshi-ota satoshi-ota force-pushed the chore/add-prefix-ablc branch from 622ec5e to 17e826c Compare June 6, 2024 09:49
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) June 6, 2024 09:52
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esteve
Copy link
Contributor

esteve commented Jun 6, 2024

@satoshi-ota please coordinate with @xmfcx and me when doing these refactorings to avoid duplicates. Also, the PRs you're submitting are missing the namespace rename (code must live in autoware::). Thanks

@satoshi-ota
Copy link
Contributor Author

@satoshi-ota please coordinate with @xmfcx and me when doing these refactorings to avoid duplicates.

HI @esteve . Thanks for your comment. I missed your PR. Can your PR merge soon?

Also, the PRs you're submitting are missing the namespace rename (code must live in autoware::). Thanks

I known but I'm going to add autoware:: after all bpp packge name modified in order to keep build passing and prevent conflict.

@satoshi-ota satoshi-ota changed the title chore(autoware_behavior_path_avoidance_by_lane_change_module): add prefix autoware_ refactor(behavior_path_avoidance_by_lane_change_module)!: prefix package and namespace with autoware Jun 7, 2024
@satoshi-ota satoshi-ota closed this Jun 7, 2024
auto-merge was automatically disabled June 7, 2024 23:41

Pull request was closed

@satoshi-ota satoshi-ota deleted the chore/add-prefix-ablc branch June 7, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants