Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): refactor transit failure function #9835

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Jan 7, 2025

Description

Refactoring canTransitToFailState function. Reduce similar computation, and reduce nested loop. Also added debug marker for visualizing state and the transitioning reason.

Related links

Parent Issue:

  • Link

How was this PR tested?

  1. PSIM
  2. TIER IV Internal link

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review January 7, 2025 13:18
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 36.73469% with 31 lines in your changes missing coverage. Please review.

Project coverage is 29.62%. Comparing base (7fb4c1b) to head (56fa3ec).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...behavior_path_lane_change_module/src/interface.cpp 7.14% 26 Missing ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 3 Missing ⚠️
...vior_path_lane_change_module/src/utils/markers.cpp 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9835   +/-   ##
=======================================
  Coverage   29.62%   29.62%           
=======================================
  Files        1452     1454    +2     
  Lines      108921   108917    -4     
  Branches    42577    42575    -2     
=======================================
+ Hits        32265    32272    +7     
+ Misses      73421    73410   -11     
  Partials     3235     3235           
Flag Coverage Δ *Carryforward flag
differential 20.93% <36.73%> (?)
total 29.63% <ø> (+0.01%) ⬆️ Carriedforward from 7fb4c1b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkquda mkquda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 4dc7201 into autowarefoundation:main Jan 10, 2025
49 of 50 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the RT1-8953-refactor-transit-failure branch January 10, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants