Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port autoware_interpolation from autoware.universe #149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shulanbushangshu
Copy link

Description

Port autoware_interpolation from Autoware.Universe

Related links

#139
Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: jack.song <[email protected]>
Copy link

github-actions bot commented Jan 3, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@shulanbushangshu shulanbushangshu changed the title feat: Port autoware_interpolation from Autoware.Universe feat: port autoware_interpolation from Autoware.Universe Jan 3, 2025
@shulanbushangshu shulanbushangshu changed the title feat: port autoware_interpolation from Autoware.Universe feat: port autoware_interpolation from autoware.universe Jan 3, 2025
@mitsudome-r mitsudome-r requested a review from rej55 January 7, 2025 15:31
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it’s a porting task, I’m keeping the review to a minimum.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Autoware Core will be renumbering its version, please delete the CHANGELOG.rst for now.

<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>autoware_interpolation</name>
<version>0.40.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>0.40.0</version>
<version>0.0.0</version>

Comment on lines +40 to +49
$$
\begin{align}
Y_i (x_i) & = y_i \ \ \ (i = 0, \dots, N-1) \\
Y_i (x_{i+1}) & = y_{i+1} \ \ \ (i = 0, \dots, N-1) \\
Y'_i (x_{i+1}) & = Y'_{i+1} (x_{i+1}) \ \ \ (i = 0, \dots, N-2) \\
Y''_i (x_{i+1}) & = Y''_{i+1} (x_{i+1}) \ \ \ (i = 0, \dots, N-2) \\
Y''_0 (x_0) & = 0 \\
Y''_{N-1} (x_N) & = 0
\end{align}
$$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LaTeX notation is being displayed as plain text. Please review the notation.
https://github.com/shulanbushangshu/autoware.core/tree/interp/common/autoware_interpolation#spline-interpolation-algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants