-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(autoware_geography_utils): add lanelet2_projector
test
#128
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 73.25% 79.18% +5.93%
==========================================
Files 10 11 +1
Lines 172 197 +25
Branches 68 75 +7
==========================================
+ Hits 126 156 +30
+ Misses 19 11 -8
- Partials 27 30 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, get_lanelet2_projector
is used in project_forward
std::unique_ptr<lanelet::Projector> projector = get_lanelet2_projector(projector_info); |
and project_forward
is already tested in
autoware::geography_utils::project_forward(geo_point, projector_info); |
So, to some extent, get_lanelet2_projector
is indirectly tested.
However, it is still okay to test it explicitly.
Since it is a unit test, I believe it is best to write tests for each smallest unit. |
Description
This adds
lanelet2_projector
test.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.