Skip to content

Commit

Permalink
add todo
Browse files Browse the repository at this point in the history
Signed-off-by: M. Fatih Cırıt <[email protected]>
  • Loading branch information
M. Fatih Cırıt committed Apr 22, 2024
1 parent 3641b52 commit 3d6ff2e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,9 @@ void AutowareControlCenter::on_startup()

using ServiceResponseFuture = rclcpp::Client<
autoware_control_center_msgs::srv::AutowareControlCenterDeregister>::SharedFuture;
// performance-unnecessary-value-param is not recognized by cpplint

// performance-unnecessary-value-param
// TODO(xmfcx): add the line above the line below once next cpplint is released (1.7.0 or 2.0.0)
// NOLINTNEXTLINE
auto response_received_callback = [this](const ServiceResponseFuture future) {
const auto & response = future.get();
Expand Down
6 changes: 4 additions & 2 deletions common/autoware_node/src/autoware_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ void AutowareNode::send_state(
RCLCPP_DEBUG(get_logger(), "Send node state");
}

// performance-unnecessary-value-param is not recognized by cpplint
// performance-unnecessary-value-param
// TODO(xmfcx): add the line above the line below once next cpplint is released (1.7.0 or 2.0.0)
// NOLINTNEXTLINE
void AutowareNode::node_register_future_callback(AutowareNodeRegisterServiceResponseFuture future)
{
Expand All @@ -182,7 +183,8 @@ void AutowareNode::node_register_future_callback(AutowareNodeRegisterServiceResp
}
}

// performance-unnecessary-value-param is not recognized by cpplint
// performance-unnecessary-value-param
// TODO(xmfcx): add the line above the line below once next cpplint is released (1.7.0 or 2.0.0)
// NOLINTNEXTLINE
void AutowareNode::node_error_future_callback(AutowareNodeErrorServiceResponseFuture future)
{
Expand Down

0 comments on commit 3d6ff2e

Please sign in to comment.