feat(clang-tidy): determine error using exit_code #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kobayu858 <[email protected]>
Signed-off-by: kobayu858 <[email protected]>
veqcc
reviewed
Dec 10, 2024
veqcc
reviewed
Dec 10, 2024
Signed-off-by: kobayu858 <[email protected]>
|
@xmfcx @mitsudome-r |
xmfcx
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored error determination for CI when using run-clang-tidy because it was not working properly.
Instead of looking for errors in the log with
grep, change to determine them byexit_codein run-clang-tidy.Related links
How was this PR tested?
Tested on this PR.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior