Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added more ROS 2 SLAM Implementations #623

Closed
wants to merge 0 commits into from

Conversation

horverno
Copy link
Contributor

@horverno horverno commented Nov 7, 2024

Description

Added more ROS 2 SLAM Implementations such as DLIO and KISS-ICP. Also updated the list and fixed some small typos.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@horverno horverno changed the title Added more ROS 2 SLAM Implementations docs: Added more ROS 2 SLAM Implementations Nov 20, 2024
@horverno
Copy link
Contributor Author

Can somebody please assign reviewer to this issue @TaikiYamada4 @isamu-takagi thanks!

Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@horverno
I have no complaints about what you add but could you order them up with an alphabetical order?

Plus, could you do these two to pass the CI?

  • Modify Added to added in your PR title
  • Have your commits signed

@horverno horverno changed the title docs: Added more ROS 2 SLAM Implementations docs: added more ROS 2 SLAM Implementations Nov 21, 2024
@horverno
Copy link
Contributor Author

@TaikiYamada4
thanks, done:

  • Modify Added to added in your PR title
  • Have your commits signed

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified on Nov 21, 2024, 12:05 PM

Also, I fixed pre-commit error: 1 dead links found.

@TaikiYamada4
Copy link
Contributor

@horverno
Could you sort the SLAM methods in the alphabetical order as I said before?
Besides, the DCO isn't passed so your signed commits seems to be wrong yet.
Could you also check the details of the DCO log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants