Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node_diagram): update perception and sensing pipeline #482

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 16, 2023

Description

Update Perception and Sensing pipeline to the latest. Note that the node diagram fully illustrates the pipeline including the radar pipeline.

INTERNAL LINK

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda requested review from yukkysaito and miursh November 16, 2023 07:46
@kminoda kminoda added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 16, 2023
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-482/
Modified URLs:

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating! I have some minor changes to request:

  1. Change 'tensorrt_yolo' to 'tensorrt_yolox.'
  2. Change line jumps to 'Arc' when two lines cross.
  3. Add a pointcloud topic as input for the 'traffic_light_occlusion_predictor."

Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
@kminoda
Copy link
Contributor Author

kminoda commented Nov 16, 2023

@miursh Thank you for the comment. All the points have been addressed in the latest version.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 3a47480 into autowarefoundation:main Nov 16, 2023
8 checks passed
@kminoda kminoda deleted the chore/node_diagram/update_perception_and_sensing branch November 16, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants