-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component-interface): add component interface list #279
base: main
Are you sure you want to change the base?
feat(component-interface): add component interface list #279
Conversation
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
|
||
interfaces: | ||
- name: /localization/initialization_state | ||
type: autoware_adapi_v1_msgs/msg/LocalizationInitializationState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making it independent of autoware_adapi_v1_msgs?
I think it would be better to close the interaction between components to component interface msgs only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either is fine. We can separate it now for consistency, or copy and edit it later when we need. Is it better to separate now?
Signed-off-by: Takagi, Isamu <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: Takagi, Isamu <[email protected]>
I've just seen this list, thanks for working on this. I have some long-term ideas about this topic. Having a documentation for these interfaces is great. But keeping this document up-to-date or have it reflect the latest changes it challenging. Maybe we can create a tool to dynamically analyze the Autoware to ensure:
This would require a lot of work and needs to be thought thoroughly. @isamu-takagi what do you think? |
Signed-off-by: Takagi, Isamu <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: Takagi, Isamu [email protected]
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.