feat: enable side lidars and adjust positions #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mozhoku
added
type:bug
brkay54
approved these changes
Apr 18, 2024
7 tasks
|
could you rebase this to the main? |
mozhoku
force-pushed
the
chore/adjust-lidar-positions-for-lexus
branch
from
073f59c to
29aa85f
Compare
Signed-off-by: Alptuğ Cırıt <[email protected]>
mozhoku
force-pushed
the
chore/adjust-lidar-positions-for-lexus
branch
from
29aa85f to
ea8b572
Compare
xmfcx
changed the title
xmfcx
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled side lidars on the Lexus by default and adjusted positions slightly
Related links
Related Issue:
Related PR:
Tests performed
I've tested autonomous driving in Nishishinjuku environment with the side/top lidars enabled with the new configuration.
Effects on system behavior
No effect.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.