Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more rpc endpoints #383

Merged
merged 1 commit into from
Nov 28, 2024
Merged

add more rpc endpoints #383

merged 1 commit into from
Nov 28, 2024

Conversation

DaMandal0rian
Copy link
Member

@DaMandal0rian DaMandal0rian commented Nov 28, 2024

PR Type

enhancement


Description

  • Enhanced the domain routing rules in the create_domain_node_compose_file.sh and create_rpc_node_compose_file.sh scripts.
  • Added autonomys.xyz as a valid domain option in the traefik.http.routers.archival-node.rule.

Changes walkthrough 📝

Relevant files
Enhancement
create_domain_node_compose_file.sh
Enhance domain routing rules in compose file                         

templates/scripts/create_domain_node_compose_file.sh

  • Updated the traefik.http.routers.archival-node.rule to include
    additional domain options.
  • Added autonomys.xyz as a valid domain in the rule.
  • +1/-1     
    create_rpc_node_compose_file.sh
    Enhance domain routing rules in RPC compose file                 

    templates/scripts/create_rpc_node_compose_file.sh

  • Updated the traefik.http.routers.archival-node.rule to include
    additional domain options.
  • Added autonomys.xyz as a valid domain in the rule.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Redundant Rule
    The routing rule for the archival-node contains redundant domain entries. This might be a typo or copy-paste error. It should be reviewed to ensure correct domain routing.

    Redundant Rule
    Similar to the domain node script, the routing rule for the archival-node in the RPC node script contains redundant domain entries. This should be corrected to avoid potential misconfigurations.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Simplify the Traefik router rule by removing duplicate domain patterns

    Simplify the Traefik router rule by removing redundant domain patterns. The rule
    contains duplicate domain entries which can be streamlined.

    templates/scripts/create_domain_node_compose_file.sh [90]

    -- "traefik.http.routers.archival-node.rule=Host(\`\${DOMAIN_PREFIX}-\${NODE_ID}.\${NETWORK_NAME}.subspace.network || \${DOMAIN_PREFIX}-\${NODE_ID}.\${NETWORK_NAME}.subspace.network || \${DOMAIN_PREFIX}-\${NODE_ID}.\${NETWORK_NAME}.autonomys.xyz\`) && Path(\`/ws\`)"
    +- "traefik.http.routers.archival-node.rule=Host(\`\${DOMAIN_PREFIX}-\${NODE_ID}.\${NETWORK_NAME}.subspace.network || \${DOMAIN_PREFIX}-\${NODE_ID}.\${NETWORK_NAME}.autonomys.xyz\`) && Path(\`/ws\`)"
    Suggestion importance[1-10]: 7

    Why: The suggestion correctly identifies and removes a redundant domain pattern in the Traefik router rule, which simplifies the configuration and avoids potential confusion or errors in routing.

    7

    @DaMandal0rian DaMandal0rian merged commit 60a1419 into main Nov 28, 2024
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the feat/add-rpc-endpoints branch November 28, 2024 17:03
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant