Add prettier to auto-kol/agent #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove linting for now
jfrank-summit
force-pushed
the
add-prettier
branch
from
842722d to
c742c30
Compare
jfrank-summit
force-pushed
the
add-prettier
branch
from
c742c30 to
0a336b4
Compare
marc-aurele-besner
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
All good with me, I'll just suggest also adding a .vscode/settings.json with similar lines as here to avoid actually having to remember to run prettier each time we are committing something
I have a local vscode settings that runs on save. I know you like committing those to the repo. Another one I'm pretty indifferent on. |
Xm0onh
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to standardize the code formatting I have added prettier. @marc-aurele-besner is more experienced and probably opinionated regarding formatting, so please review and feel free to improve.
I will also be adding linting after we get through some refactoring.