-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto chain agent -> memory enabled + enhanced frontend #21
Conversation
… history functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
auto-chain-agent/package.json
Outdated
"resolutions": { | ||
"@polkadot/types": "14.3.1", | ||
"@polkadot/types-create": "14.3.1", | ||
"@polkadot/types-codec": "14.3.1", | ||
"@polkadot/api": "14.3.1", | ||
"@polkadot/api-derive": "14.3.1", | ||
"@polkadot/rpc-core": "14.3.1" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we needing to add these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I was getting conflicting pkg for polkadot type. I added resolutions to fix it.
@polkadot/types has multiple versions, ensure that there is only one installed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably something that should be fixed at the auto-sdk level. @marc-aurele-besner any ideas here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think I found the problem.
This is the dependency chain:
@autonomys/auto-utils ├─► @polkadot/[email protected] └─► @polkadot/[email protected] └─► @polkadot/extension-inject └─► @polkadot/[email protected]
@autonomys/auto-utils
directly depends on:
@polkadot/[email protected]
@polkadot/[email protected]
But @polkadot/[email protected]
depends on:
@polkadot/extension-inject
which requires @polkadot/[email protected]
I think upgrading polkadot/api to 14.3.1 in @autonomys/auto-utils
might solve the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I made a PR for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[email protected] should have the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marc-aurele-besner !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces/enhances the following: