Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup basic function to connect to the rpc consensus #6

Merged
merged 23 commits into from
Jun 4, 2024
Merged

Setup basic function to connect to the rpc consensus #6

merged 23 commits into from
Jun 4, 2024

Conversation

marc-aurele-besner
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner commented Jun 3, 2024 •
edited
Loading

Setup basic function to connect to the rpc consensus

  • Define the networks in a constants file (and types)
  • Define default network
  • Make a function that returns the network details from its id
  • Make a function that connects to a specific network of default network
  • Make functions that return network details
  • Make simple tests for all the above

Reproduce

yarn build
yarn test

Note that I move to use yarn berry

yarn set version berry
yarn

@marc-aurele-besner marc-aurele-besner linked an issue Jun 3, 2024 that may be closed by this pull request
Setup basic function to connect to the RPC (consensus) #3
Closed
6 tasks
abhi3700
abhi3700 previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@abhi3700 abhi3700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jfrank-summit
jfrank-summit reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@jfrank-summit jfrank-summit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments on structure.

packages/auto-consensus/src/api.ts Outdated Show resolved Hide resolved
packages/auto-consensus/src/network.ts Outdated Show resolved Hide resolved
jfrank-summit
jfrank-summit approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-aurele-besner marc-aurele-besner merged commit 5207b22 into main Jun 4, 2024
4 checks passed
@marc-aurele-besner marc-aurele-besner deleted the 3-setup-basic-function-to-connect-to-the-rpc-consensus branch June 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrank-summit jfrank-summit jfrank-summit approved these changes

@abhi3700 abhi3700 Awaiting requested review from abhi3700

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup basic function to connect to the RPC (consensus)
3 participants
@marc-aurele-besner @abhi3700 @jfrank-summit